AFTER_START_TIMING_ADVANCE is temp based

[RomChip200]

Hi,

AFTER_START_TIMING_ADVANCE is temperature based, please correct it.

AFTER_START_TIMING_RETARD is RPM based, which is correct.

[Matt]

See what you mean:

HCR32 (base file)
TIMING_ADVANCE,&H7EC0,16,1,16,1 (Temperature)
AFTER_START_TIMING_ADVANCE,&H7BE0,16,1,16,1 (RPM)
AFTER_START_TIMING_RETARD,&H7540,16,1,16,1

Code: Select all

BA74 : B6 14 5D 	"  ]"		ldaa	145D_RAM_TEMP_IDX
BA77 : CE FE C0 	"   "		ldx	#ROM_FEC0_ROM_TIMING_ADVANCE_VS_TEMP
BA7A : BD 80 9F 	"   "		jsr	809F_Lookup_16
BA7D : 36 		"6"		psha
BA7E : B6 15 44 	"  D"		ldaa	RAM_1544_RPM_IDXDiv2
BA81 : CE FB E0 	"   "		ldx	#ROM_FBE0_ROM_AFTER_START_TIMING_ADVANCE_VS_RPM
BA84 : BD 80 9F 	"   "		jsr	809F_Lookup_16

Code: Select all

CBCC : B6 14 73 	"  s"		ldaa	RAM_1473_RPM_IDX
CBCF : CE F5 40 	"  @"		ldx	#ROM_F540_AFTER_START_TIMING_RETARD
CBD2 : BD 80 EF 	"   "		jsr	SUB_80EF_Interp_Tablex16
CBD5 : B7 15 57 	"  W"		staa	RAM_1557_Timing_RPM_subtract_val
CBD8 : 96 B6 		"  "		ldaa	RAM_00B6_Coolant_Temp_Copy2
CBDA : CE FE C0 	"   "		ldx	#ROM_FEC0_BCADV_AFTER_START_TIMING_ADVANCE
CBDD : BD 80 EF 	"   "		jsr	SUB_80EF_Interp_Tablex16
CBE0 : B7 15 56 	"  V"		staa	RAM_1556_Timing_RPM_add_val
CBE3 : B0 15 57 	"  W"		suba	RAM_1557_Timing_RPM_subtract_val

We overwrite this for Z32 with
AFTER_START_TIMING_ADVANCE,&H7EC0,16,1,16,1

Which is incorrect. This should be removed and keep original base TIMING_ADVANCE (vs temp). Updated address file attached